Add snoretoast icon
ClosedPublic

Authored by ndavis on Jun 27 2019, 6:51 PM.

Details

Reviewers
vonreth
Group Reviewers
VDG
Commits
R834:d600673fa89a: Add snoretoast icon
Summary

This is a single SVG with the snoretoast icon at 48x48, 32x32, 24x24, 22x22 and 16x16 so that it can be turned into an ICO file for Windows.

FEATURE: 409242

Test Plan

Diff Detail

Repository
R834 SnoreToast
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis requested review of this revision.Jun 27 2019, 6:51 PM
ndavis created this revision.
ndavis edited the test plan for this revision. (Show Details)
ndavis edited the summary of this revision. (Show Details)Jun 27 2019, 7:16 PM

I learned the hard way what errors you can make during export πŸ™ˆ (if you have no idea what your doing)
Could you already dump the png's?

(I love them)

ndavis updated this revision to Diff 60744.Jun 27 2019, 7:43 PM
  • Add pngs

You don't actually need the 22px version for Windows, but since KDE Applications use that size, I figured I should put it in the SVG in case you ever need it.

# According to https://stackoverflow.com/a/40851713/2886832
# Windows always chooses the first icon above 255px, all other ones will be ignored

When would the 1024px version be needed? It's 240KB vs 33KB for 256px.

Ah your right.

I think a bigger one than 265 could be used here (windows start menu)

vonreth accepted this revision.Jun 27 2019, 8:19 PM

I love them and this should be enough :D

This revision is now accepted and ready to land.Jun 27 2019, 8:19 PM

I think a bigger one than 265 could be used here (windows start menu)

256 should be more than large enough for the start menu tiles. Perhaps Windows is looking for an icon size between 48px and 256px?

ndavis updated this revision to Diff 60746.Jun 27 2019, 8:22 PM
  • Add 96px png

The WhatsApp icon seems to be about 96px, if it has margins.

ndavis retitled this revision from Add data/snoretoast.svg to Add snoretoast icon.Jun 27 2019, 8:24 PM
This revision was automatically updated to reflect the committed changes.