Differential D22112

Prefer logging in via the saved auth token
ClosedPublic
Actions

Authored by cdywan on Jun 27 2019, 7:58 AM.

Details

Reviewers
mlaurent
Commits
R865:a3f0e539cc41: Patch from Christian Dywan
Summary

This in particular avoids re-authenticating with a 2FA code every time Ruqola is opened (see bug 409212).

BUG: 409213

Diff Detail

Repository
R865 Ruqola
Lint
Lint Skipped
Unit
Unit Tests Skipped
cdywan requested review of this revision.Jun 27 2019, 7:58 AM
cdywan created this revision.
mlaurent requested changes to this revision.Jun 27 2019, 11:45 AM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
src/ruqolacore/ddpapi/ddpclient.cpp
894

else if (...) no ?

This revision now requires changes to proceed.Jun 27 2019, 11:45 AM
cdywan updated this revision to Diff 60730.Jun 27 2019, 1:53 PM

Fixed the if to be an else if.

cdywan marked an inline comment as done.Jun 27 2019, 1:53 PM
mlaurent added a comment.Jun 28 2019, 4:39 AM

It's ok but update from last git I made a little change.
Thanks

cdywan added a comment.EditedJun 28 2019, 8:39 AM
In D22112#487531, @mlaurent wrote:

It's ok but update from last git I made a little change.
Thanks

Thanks for pointing it out. It doesn't seem like Phabricator shows conflicts. ☹️

cdywan updated this revision to Diff 60757.Jun 28 2019, 9:06 AM

Rebased against master.

mlaurent accepted this revision.Jun 28 2019, 11:29 AM

Ok thanks.
Do you have commit access ?

This revision is now accepted and ready to land.Jun 28 2019, 11:29 AM
cdywan added a comment.Jun 28 2019, 11:33 AM
In D22112#487581, @mlaurent wrote:

Ok thanks.
Do you have commit access ?

Probably not. I signed up for everything this week, haha.

mlaurent added a comment.Jun 28 2019, 11:38 AM

If you want I can commit for you :)

cdywan added a comment.Jun 28 2019, 11:41 AM
In D22112#487604, @mlaurent wrote:

If you want I can commit for you :)

That would be much appreciated!

I'd like to become a regular contributor long-term. Maybe setting up CI and merging of approved commits is something I could work on? I'll need to figure how things work in KDE land, though.

Closed by commit R865:a3f0e539cc41: Patch from Christian Dywan (authored by mlaurent). · Explain WhyJun 28 2019, 12:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ruqolacore/ddpapi/ddpclient.cpp (12 lines)

Diff 60730

View Options

src/ruqolacore/ddpapi/ddpclient.cpp

Loading...