bring back disc headers for multi disc albums
ClosedPublic

Authored by mgallien on Jun 27 2019, 5:26 AM.

Details

Summary

put a small section header to indicate the disc number in the album view

Test Plan

only albums with mutiple discs show disc headers

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.Jun 27 2019, 5:26 AM
mgallien created this revision.
pino added a subscriber: pino.Jun 27 2019, 5:28 AM
pino added inline comments.
src/qml/TracksDiscHeader.qml
30

I guess this requires i18n, as it is a UI visibile string

mgallien added inline comments.Jun 27 2019, 5:59 AM
src/qml/TracksDiscHeader.qml
30

Thanks. It needs it and so cannot land on stable branch.

mgallien updated this revision to Diff 60748.Jun 27 2019, 8:43 PM

rebase on master and use i18n proper call

ngraham accepted this revision.Jun 28 2019, 3:28 PM
ngraham added a subscriber: ngraham.

LGTM

This revision is now accepted and ready to land.Jun 28 2019, 3:28 PM
This revision was automatically updated to reflect the committed changes.