[TabBar] Remove exterior margins
ClosedPublic
Actions

Authored by filipf on Jun 26 2019, 7:38 PM.

Details

Reviewers

ngraham
ndavis

Group Reviewers

VDG
Plasma

Commits

R242:97272465a8b4: [TabBar] Remove exterior margins

Summary

This allows us to glide active tabbar indicators on lines, which we cannot do now in Kickoff due to this limitation in the control.

Test Plan

Before:

After:

Diff Detail

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

filipf created this revision.Jun 26 2019, 7:38 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJun 26 2019, 7:38 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

filipf requested review of this revision.Jun 26 2019, 7:38 PM

Harbormaster completed remote builds in B13329: Diff 60704.Jun 26 2019, 7:38 PM

filipf edited the test plan for this revision. (Show Details)Jun 26 2019, 7:38 PM

filipf added reviewers: VDG, Plasma, ngraham.

Makes sense to me, but why are the computer icons different? ^^'

In D22108#487140, @apol wrote:

Makes sense to me, but why are the computer icons different? ^^'

Some bug in Kickoff or with the icon, sometimes (maybe after you change a desktop theme) it shows the laptop icon, and then after a while the monitor icon. Should have made another screenshot but oh well :P

1+ visually. How does it look with a vertical panel?

In D22108#487218, @ndavis wrote:

1+ visually. How does it look with a vertical panel?

Still not gliding on the line, but that should be resolved in Kickoff somehow:

In D22108#487329, @filipf wrote:

In D22108#487218, @ndavis wrote:

1+ visually. How does it look with a vertical panel?

Still not gliding on the line, but that should be resolved in Kickoff somehow: