Kirigami separators are currently stronger than Breeze style borders used with controls.
With this patch the difference between the two should no longer be observable.
ngraham |
Kirigami | |
VDG |
Kirigami separators are currently stronger than Breeze style borders used with controls.
With this patch the difference between the two should no longer be observable.
Breeze
Before:
Breeze Dark
Before:
No Linters Available |
No Unit Test Coverage |
Buildable 13327 | |
Build 13345: arc lint + arc unit |
Although testing with other color schemes there is clearly an underlying difference in the code between how the Kirigami separator determines the color and Breeze:
If someone could point me to the place in Breeze that does this I could try to replicate the exact thing.
Maybe we should have the Theme provide the opacity somehow?
You can look at the kde:breeze repository for the kstyle and others.
Widgets style: https://cgit.kde.org/breeze.git/tree/kstyle/breezehelper.cpp#n76
Qtquickcontrols style is pretty inconsistent and uses 0.2, 0.25, 0.3 alpha and either color mixing or transparent text color.
+1 visually, but I agree that the Breeze Widget theme should be the part that provides the theming, if possible.
Hmm I tried to copy that code and it also produced good results with Breeze and Breeze Dark, but could be way off with other themes.
Long term, we should make this more programmatic.
But since there's already a magic number in there, I think it makes sense to use a better one for the time being.
Phab hasn't picked up on the commit: https://cgit.kde.org/kirigami.git/commit/?id=9af92cc8b750b59629eeb3446108b2f8086629f7
Please note that depending on the repository. Phabricator can take anywhere from a minute or two, to update to an hour to pick up changes to a repository (it polls repositories unfortunately, and those with more frequent changes are polled more often by Phabricator)