[Separator] Match Breeze borders' color
ClosedPublic

Authored by filipf on Jun 26 2019, 5:39 PM.

Details

Summary

Kirigami separators are currently stronger than Breeze style borders used with controls.

With this patch the difference between the two should no longer be observable.

Test Plan

Breeze
Before:


After:

Breeze Dark
Before:


After:

Diff Detail

Repository
R169 Kirigami
Branch
tweak-separator-color (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13327
Build 13345: arc lint + arc unit
filipf created this revision.Jun 26 2019, 5:39 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptJun 26 2019, 5:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Jun 26 2019, 5:39 PM
filipf edited the test plan for this revision. (Show Details)Jun 26 2019, 5:40 PM
filipf added reviewers: Kirigami, VDG, ngraham.

Although testing with other color schemes there is clearly an underlying difference in the code between how the Kirigami separator determines the color and Breeze:

If someone could point me to the place in Breeze that does this I could try to replicate the exact thing.

apol added a subscriber: apol.Jun 27 2019, 10:16 AM

Maybe we should have the Theme provide the opacity somehow?

You can look at the kde:breeze repository for the kstyle and others.

mglb added a subscriber: mglb.Jun 27 2019, 1:38 PM

Widgets style: https://cgit.kde.org/breeze.git/tree/kstyle/breezehelper.cpp#n76

Qtquickcontrols style is pretty inconsistent and uses 0.2, 0.25, 0.3 alpha and either color mixing or transparent text color.

ndavis added a subscriber: ndavis.Jun 27 2019, 4:55 PM

+1 visually, but I agree that the Breeze Widget theme should be the part that provides the theming, if possible.

In D22106#487287, @mglb wrote:

Widgets style: https://cgit.kde.org/breeze.git/tree/kstyle/breezehelper.cpp#n76

Qtquickcontrols style is pretty inconsistent and uses 0.2, 0.25, 0.3 alpha and either color mixing or transparent text color.

Hmm I tried to copy that code and it also produced good results with Breeze and Breeze Dark, but could be way off with other themes.

ngraham accepted this revision.Sep 5 2019, 7:51 PM

Long term, we should make this more programmatic.

But since there's already a magic number in there, I think it makes sense to use a better one for the time being.

This revision is now accepted and ready to land.Sep 5 2019, 7:51 PM

Please note that depending on the repository. Phabricator can take anywhere from a minute or two, to update to an hour to pick up changes to a repository (it polls repositories unfortunately, and those with more frequent changes are polled more often by Phabricator)