Hopefully did everything right. The only bigger change is in FileMetaDataProvider::label(...)
Everything is changed to get it compiling, string concatenation etc are otherwise left unchanged

bruns added inline comments.Jun 26 2019, 2:58 PM

autotests/filemetadatadatedisplaytest.cpp
44	use the `QLocale(Language, Country)` constructor here, dito below. https://doc.qt.io/qt-5/qlocale.html#QLocale-2
src/filemetadataprovider.cpp
410–411	You can use an initializer list here, like in `FileMetaDataProvider::label(...)`
src/kedittagsdialog.cpp
135	`.endsWith` has a QLatin1String overload

use qlatin1string for endswith
use enums for qlocale
use initializer list

Harbormaster completed remote builds in B13352: Diff 60745.Jun 27 2019, 8:17 PM

bruns added inline comments.Jun 27 2019, 9:51 PM

src/kcommentwidget.cpp
73	`... + comment.toHtmlEscaped() + ...`

remove unrequired QString()

Harbormaster completed remote builds in B13405: Diff 60832.Jun 29 2019, 10:14 AM

bruns accepted this revision.Jun 29 2019, 3:51 PM

This revision is now accepted and ready to land.Jun 29 2019, 3:51 PM

Closed by commit R824:48c2cb91f66a: Check for DQT_NO_CAST_FROM_ASCII (authored by astippich). · Explain WhyJun 29 2019, 7:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (1 line)
M			autotests/filemetadatadatedisplaytest.cpp (10 lines)
M			autotests/filemetadataitemcounttest.cpp (4 lines)
M			autotests/filemetadatawidgettest.cpp (22 lines)
M			src/filemetadataconfigwidget.cpp (16 lines)
M			src/filemetadataprovider.cpp (180 lines)
M			src/filemetadatawidget.cpp (4 lines)
M			src/kcommentwidget.cpp (10 lines)
M			src/kedittagsdialog.cpp (2 lines)
M			src/metadatafilter.cpp (4 lines)
M			src/tagcheckbox.cpp (2 lines)
M			src/tagsfileitemactionplugin/tagsfileitemaction.cpp (2 lines)
M			src/tagwidget.cpp (2 lines)
M			src/widgetfactory.cpp (2 lines)
M			test/metadataconfigwidgetapp.cpp (2 lines)
M			test/metadatawidgetapp.cpp (4 lines)
M			test/tagwidgetapp.cpp (2 lines)
M			test/tagwidgettest.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	60663	b9fcf84		Jun 25 2019, 6:32 PM	★	★
Diff 2	60745	b9fcf84	- use qlatin1string for endswith	Jun 27 2019, 8:17 PM	★	★
Diff 3	60832	b9fcf84	- remove unrequired QString()	Jun 29 2019, 10:14 AM	★	★
Diff 4	60846	b9fcf84	R824:48c2cb91f66a4061b33ace4728905861c31a688f	Jun 29 2019, 6:33 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
1c6b88bdc330	cf4a7a1463e2	da8667db3c8c	Alexander Stippich	remove unrequired QString()	Jun 29 2019, 10:14 AM
da8667db3c8c	cf24d796a8f8	d56b007fbe20	Alexander Stippich	use initializer list	Jun 27 2019, 6:04 PM
d56b007fbe20	e9351ba8207f	c5216add67b7	Alexander Stippich	use enums for qlocale	Jun 27 2019, 6:01 PM
c5216add67b7	21aea3d6674b	7a304d660757	Alexander Stippich	use qlatin1string for endswith	Jun 27 2019, 5:59 PM
7a304d660757	4f04c9700b94	7b83529f88c9	Alexander Stippich	Check for DQT_NO_CAST_FROM_ASCII (Show More…)	Jun 25 2019, 6:17 PM
7b83529f88c9	400d096022c2	b9fcf84f7fa3	Alexander Stippich	fix strings	Jun 25 2019, 6:10 PM