Don't show progress window for jobs that don't report progress
AbandonedPublic

Authored by nicolasfella on Jun 25 2019, 4:44 PM.

Details

Reviewers
apol
ngraham
Summary

Most plugins (all but the youtube one) don't report any progress in their jobs. This results in a window with an empty progress bar flashing for a few seconds. Let's hide the window by default and allow plugins to enable it.

Test Plan

Shared stuff via imgur/telegram. No window appears. Share stuff via KDE Connect. Window disappears after selecting a device

Diff Detail

Repository
R495 Purpose Library
Branch
noprogress
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13301
Build 13319: arc lint + arc unit
nicolasfella created this revision.Jun 25 2019, 4:44 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 25 2019, 4:44 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jun 25 2019, 4:44 PM
apol added a comment.Jun 25 2019, 10:17 PM

I think it's valuable information that the job is in progress. How about making the progress bar indeterminate?

https://doc.qt.io/qt-5/qml-qtquick-controls2-progressbar.html#indeterminate-prop

I find myself agreeing with @apol. Here's an idea:

  • Don't show the progress window at all for 500 milliseconds, like Plasma's Notifications. This will prevent it from unnecessarily showing up for very quick transfers when you're sending a small file via a fast internet connection, for example
  • After 500 ms, show a (correctly-sized and nice-looking) window with an indeterminate progress bar
  • Individual plugins that actually report status will instead get a regular progress bar

Does that sound sane?

nicolasfella abandoned this revision.Dec 6 2020, 4:29 PM