Build without foreach
Needs ReviewPublic

Authored by nicolasfella on Jun 25 2019, 9:04 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Test Plan

Did Plasma things

Diff Detail

Repository
R120 Plasma Workspace
Branch
arcpatch-D22087
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15352
Build 15370: arc lint + arc unit
nicolasfella created this revision.Jun 25 2019, 9:04 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 25 2019, 9:04 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jun 25 2019, 9:04 AM
apol added a subscriber: apol.Jul 27 2019, 10:59 PM

+1 overall

dataengines/powermanagement/powermanagementengine.cpp
442

const &

dataengines/share/shareengine.cpp
54 ↗(On Diff #60630)

const &

libdbusmenuqt/dbusmenushortcut_p.cpp
60

const &, also this should possibly be transformed into a splitRef.

75

this is already const, no?

weirdest foreach in KDE xD 🏅

runners/bookmarks/bookmarksrunner.cpp
86

const &?

runners/bookmarks/browsers/chrome.cpp
54

const&?

runners/bookmarks/browsers/firefox.cpp
99

const &

shell/screenpool.cpp
174–175

Iterating through keys isn't very optimal, I'd use iterators here.

nicolasfella marked 5 inline comments as done.Aug 20 2019, 2:50 PM
nicolasfella added inline comments.
libdbusmenuqt/dbusmenushortcut_p.cpp
60

Doesn't work trivially because of the token.replace() below

runners/bookmarks/browsers/chrome.cpp
54

Not trivially possible because of the 'new ProfileBookmarks(profile)' below

shell/screenpool.cpp
174–175

Agreed, but in another patch