Differential D2207

Teach AutoNavigation to center on the route-fixed position instead of GPS location, when navigating on route
ClosedPublic
Actions

Authored by sanjibanb on Jul 18 2016, 12:59 PM.

Details

Reviewers
nienhueser
rahn

Diff Detail

Repository
R34 Marble
Lint
Lint Skipped
Unit
Unit Tests Skipped
sanjibanb updated this revision to Diff 5271.Jul 18 2016, 12:59 PM
sanjibanb retitled this revision from to Teach AutoNavigation to center on the route-fixed position instead of GPS location, when navigating on route.
sanjibanb updated this object.
sanjibanb edited the test plan for this revision. (Show Details)
sanjibanb added reviewers: nienhueser, rahn.
sanjibanb set the repository for this revision to R34 Marble.
sanjibanb added a project: Marble.
sanjibanb added a subscriber: Marble.
sanjibanb updated this revision to Diff 5273.Jul 18 2016, 1:53 PM

Better naming of variable

nienhueser edited edge metadata.Jul 18 2016, 6:21 PM

Looks great, please push.

src/lib/marble/AutoNavigation.cpp
305

This should also consider whether guidance mode is enabled.

if (!routingModel->guidanceModeEnabled() || routingModel->deviatedFromRoute()) {
nienhueser accepted this revision.Jul 18 2016, 6:21 PM
nienhueser edited edge metadata.
This revision is now accepted and ready to land.Jul 18 2016, 6:21 PM
sanjibanb closed this revision.Jul 18 2016, 6:42 PM
sanjibanb marked an inline comment as done.

Thanks. Pushed :)

Revision Contents
Changeset List

PathPackages
Msrc/lib/marble/AutoNavigation.cpp (17 lines)

Diff 5273

View Options

src/lib/marble/AutoNavigation.cpp

Loading...