[KCM GridDelegate] Take into account implicitCellHeight for inner delegate height
ClosedPublic

Authored by broulik on Jun 24 2019, 3:40 PM.

Details

Summary

It only affected the cellHeight of the GridView but not the actual size of the delegate contents container inside.
The - 2 * gridUnit undoes the + 2 * gridUnit in the GridView's default implicitCellHeight

Test Plan
  • Changed view.implicitCellHeight to some arbitrary value: had the cell delegate look perfect without the contents overflowing
  • Normal KCMs like icons still look fine

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 24 2019, 3:40 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 24 2019, 3:40 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Jun 24 2019, 3:40 PM
ngraham accepted this revision.Jun 24 2019, 4:04 PM
This revision is now accepted and ready to land.Jun 24 2019, 4:04 PM
mart accepted this revision.Jun 25 2019, 10:31 AM
This revision was automatically updated to reflect the committed changes.