Added scriptDir to ScriptErrorFilterStrategy constructor to append it to relative paths
Added indicators to tell between error, warning and notice messages
ScriptErrorFilterStrategy: Cleanup prior to submitting the patch
Added scriptDir to ScriptErrorFilterStrategy constructor to append it to relative paths
Added indicators to tell between error, warning and notice messages
ScriptErrorFilterStrategy: Cleanup prior to submitting the patch
I work on a daily basis with PHP projects and I'm testing all their outputs items
No Linters Available |
No Unit Test Coverage |
Buildable 15688 | |
Build 15706: arc lint + arc unit |
This patch adds some patterns to ScriptErrorFilterStrategy to handle some PHP errors so that you can click on the message and the matching file is opened.
Some comments:
ScriptErrorFilteringStrategyFix: all the items where set as InformativeItem even when there were no matches
Hm, seeing all this hardcoded code for optional plugins, this calls out for someone to look into making this something pulled in from the language plugins instead :) Not your fault, just mentioning the obvious. So should be fine to just add here.
Some quick principal API/ABI comments added, otherwise added @pprkut as PHP contributor to give this a look, not anywhere my personal domain :)
kdevplatform/outputview/outputfilteringstrategies.h | ||
---|---|---|
84 ↗ | (On Diff #60549) | Make constructor explicit, scriptdir -> scriptDir. |
90 ↗ | (On Diff #60549) | For consistency, please add instead a pimpl const QScopedPointer<class ScriptErrorFilterStrategyPrivate> d; similar to CompilerFilterStrategy |
I agree that conceptually this should be moved to (or supplemented by) the actual language plugins, but also agree that this might be out of scope for this change.
As far as the PHP changes are concerned this is fine with me. However, I'd prefer those patterns to be unit tested and not just documented in comments.
Could you have a look at adding those tests?