[Task Manager] Prefer PID match even when desktop entry doesn't match
ClosedPublic

Authored by broulik on Jun 23 2019, 9:42 PM.

Details

Summary

When an application got renamed by flatpak-builder without knowing it, it will still send its original value as desktop-entry breaking the mapping. If the PID of the service matches the window owner's PID imho it's fine to assume it's a match.

Test Plan

5.16?

  • My spotify snap has media controls in its context menu and tooltip now
  • p-b-i (where the host binary doesn't match the browser window) still works for both Chrome and Firefix
  • VLC player still works

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 23 2019, 9:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 23 2019, 9:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 23 2019, 9:42 PM
hein accepted this revision.Jun 24 2019, 8:57 AM
This revision is now accepted and ready to land.Jun 24 2019, 8:57 AM
This revision was automatically updated to reflect the committed changes.