Details
Details
- Reviewers
dfaure bensi - Commits
- R4:9b07ef185e9b: Implement TaskQueries::findContexts()
Diff Detail
Diff Detail
- Repository
- R4 Zanshin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/akonadi/akonaditaskqueries.cpp | ||
|---|---|---|
| 57 | minor: this call to value() is a second lookup that was already done by contains(), so performance would be improved by using an iterator instead. | |
| 231 | Performance: you could remove the isContext() check (2 lines above) and call createContextFromItem unconditionally, it returns nullptr if the item isn't a context (so you'd do if (!context) return false;). | |