Adjust the context list property
ClosedPublic

Authored by ervin on Jun 23 2019, 6:35 PM.

Details

Summary

Align with other similar properties and use "uids" naming, since we're at it
have it manipulated as a string list since that's what it really is.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin requested review of this revision.Jun 23 2019, 6:35 PM
ervin created this revision.
dfaure requested changes to this revision.Jun 23 2019, 10:49 PM

The code changes are all about using a different name for the property and a different type (QStringList instead of QString), right? The property already existed.
The commit log is very confusing because it doesn't say that, it makes it sound like this was not handled before, and the commit now handles this by adding a new property.

This revision now requires changes to proceed.Jun 23 2019, 10:49 PM
ervin added a comment.Jun 24 2019, 6:44 AM

Right, that's because in fact I authored this before your own patch. :-)
It was stuck in my own queue because I wanted to validate it with the following commit which I struggled with. I'll change the description.

ervin retitled this revision from Handle the context uids in the serializer to Adjust the context list property.Jun 24 2019, 5:31 PM
ervin edited the summary of this revision. (Show Details)

Did the arc amend locally to reflect the description change, that should address your comment.

dfaure accepted this revision.Jun 25 2019, 6:39 AM
This revision is now accepted and ready to land.Jun 25 2019, 6:39 AM
This revision was automatically updated to reflect the committed changes.