Differential D22055

Improve Job Dialog buttons' icons and text
ClosedPublic
Actions

Authored by ngraham on Jun 23 2019, 6:15 PM.

Details

Reviewers
nicolasfella
apol
GB_2
Group Reviewers
VDG
Commits
R495:cad3d131b9b9: Improve Job Dialog buttons' icons and text
Summary

The buttons were on the wrong side of the window, lacked icons, and the affirmative
button said "run" which didn't match the verb used in the dialog's title "send".

This patch corrects those issues.

Test Plan

Diff Detail

Repository
R495 Purpose Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jun 23 2019, 6:15 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 23 2019, 6:15 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Jun 23 2019, 6:15 PM
GB_2 accepted this revision.Jun 23 2019, 6:16 PM

Thanks.

This revision is now accepted and ready to land.Jun 23 2019, 6:16 PM
nicolasfella accepted this revision.Jun 23 2019, 8:24 PM
Closed by commit R495:cad3d131b9b9: Improve Job Dialog buttons' icons and text (authored by ngraham). · Explain WhyJun 23 2019, 9:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/JobDialog.qml (10 lines)

Diff 60540

View Options

src/widgets/JobDialog.qml

Loading...