Differential D22043

Fix version number
ClosedPublic
Actions

Authored by aacid on Jun 23 2019, 1:05 PM.

Details

Reviewers
elvisangelaccio
Commits
R36:a05a3b0bce00: Fix version number
Summary

It'll now be 19.04.2 instead of 19.4.2

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Jun 23 2019, 1:05 PM
Restricted Application added a project: Ark. · View Herald TranscriptJun 23 2019, 1:05 PM
Restricted Application added subscribers: Ark, kde-utils-devel. · View Herald Transcript
aacid requested review of this revision.Jun 23 2019, 1:05 PM
elvisangelaccio added a subscriber: elvisangelaccio.Jun 23 2019, 2:55 PM

Oh boy. Has this always been broken? Shouldn't we fix cmake?

aacid added a comment.Jun 23 2019, 3:21 PM

can't confirm if it's always been like that.

OTOH this is how the rest of apps do this, so maybe it was always broken and we didn't realize?

I can try to figure out what¡s wrong in cmake and report a bug if you want, but i'd still want to land this

elvisangelaccio accepted this revision.Jun 23 2019, 4:57 PM

Sure, feel free to land it.

But I think we should report this issue to the cmake devs.

This revision is now accepted and ready to land.Jun 23 2019, 4:57 PM
Closed by commit R36:a05a3b0bce00: Fix version number (authored by aacid). · Explain WhyJun 24 2019, 3:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 60595

View Options

CMakeLists.txt

Loading...