Expose Geometry in PlasmaWindowModel.
ClosedPublic

Authored by hein on Jul 18 2016, 10:20 AM.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein updated this revision to Diff 5265.Jul 18 2016, 10:20 AM
hein retitled this revision from to Expose Geometry in PlasmaWindowModel..
hein updated this object.
hein edited the test plan for this revision. (Show Details)
hein added reviewers: Plasma, graesslin.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma on Wayland. · View Herald TranscriptJul 18 2016, 10:20 AM
graesslin requested changes to this revision.Jul 18 2016, 11:32 AM
graesslin edited edge metadata.

please also add a test to verify that the geometry actually works in the model. Right now it only verifies that the default geometry is set.

This revision now requires changes to proceed.Jul 18 2016, 11:32 AM
hein updated this revision to Diff 5266.Jul 18 2016, 11:50 AM
hein edited edge metadata.

Add test for Geometry change.

hein updated this revision to Diff 5267.Jul 18 2016, 11:53 AM
hein edited edge metadata.

Add flush.

graesslin requested changes to this revision.Jul 18 2016, 11:57 AM
graesslin edited edge metadata.
graesslin added inline comments.
autotests/client/test_plasma_window_model.cpp
446–447

you don't need to create a model. You have one in m_pw

460–461

those two should not be needed.

466

could you use different values? E.g. if we swapped width and height, we wouldn't notice.

This revision now requires changes to proceed.Jul 18 2016, 11:57 AM
hein added inline comments.Jul 19 2016, 7:27 AM
autotests/client/test_plasma_window_model.cpp
446–447

I copied that from testBooleanData

hein marked an inline comment as done.Jul 19 2016, 7:30 AM
hein added inline comments.
autotests/client/test_plasma_window_model.cpp
446–447

Also m_pw is not actually a model but a PlasmaWindowManagement :-)

hein added inline comments.Jul 19 2016, 7:32 AM
autotests/client/test_plasma_window_model.cpp
460–461

Dropped.

466

Done.

hein updated this revision to Diff 5292.Jul 19 2016, 7:35 AM
hein edited edge metadata.

Drop flush/dispatch; use different values for width and height.

graesslin requested changes to this revision.Jul 19 2016, 8:29 AM
graesslin edited edge metadata.
graesslin added inline comments.
autotests/client/test_plasma_window_model.cpp
463

and what about x and y?

This revision now requires changes to proceed.Jul 19 2016, 8:29 AM
hein updated this revision to Diff 5298.Jul 19 2016, 11:22 AM
hein edited edge metadata.

Shake up x/y.

graesslin accepted this revision.Jul 19 2016, 11:47 AM
graesslin edited edge metadata.
This revision is now accepted and ready to land.Jul 19 2016, 11:47 AM
This revision was automatically updated to reflect the committed changes.