Differential D22024

Rework sorting of properties
ClosedPublic
Actions

Authored by astippich on Jun 23 2019, 10:27 AM.

Details

Reviewers
ngraham
bruns
Commits
R824:b9fcf84f7fa3: Rework sorting of properties
Summary

Rework sorting of properties in the file
information panel and tooltips.
Rename "audio" and "music" sorting key to "media" as
they are also used for videos and images.

Final piece for

BUG: 343273

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Jun 23 2019, 10:27 AM
Restricted Application added a project: Baloo. · View Herald TranscriptJun 23 2019, 10:27 AM
Restricted Application added a subscriber: Baloo. · View Herald Transcript
astippich requested review of this revision.Jun 23 2019, 10:27 AM
astippich added a comment.Jun 23 2019, 10:29 AM

I tried to come up with reasonable sorting order, but I am of course open for discussion

astippich edited the summary of this revision. (Show Details)Jun 23 2019, 10:29 AM
ngraham accepted this revision.Jun 23 2019, 4:51 PM

Very nice :ok

This revision is now accepted and ready to land.Jun 23 2019, 4:51 PM
bruns added a comment.EditedJun 23 2019, 4:53 PM

Width and height also apply to videos..
For Video, it would be nice to have properties of the video and audio tracks kept together.

But a definitive improvement.

astippich added a comment.Jun 23 2019, 6:05 PM
In D22024#485540, @bruns wrote:

Width and height also apply to videos..

True, but they are in the same order as before, so I did not bother

For Video, it would be nice to have properties of the video and audio tracks kept together.
But a definitive improvement.

Ideally this could be done type-specific, but this is something for the other day...

Closed by commit R824:b9fcf84f7fa3: Rework sorting of properties (authored by astippich). · Explain WhyJun 23 2019, 6:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/filemetadataprovider.cpp (44 lines)

Diff 60527

View Options

src/filemetadataprovider.cpp

Loading...