Differential D22017

[Notifications] Let plasmashell be the only true owner of notification and job tracker services
ClosedPublic
Actions

Authored by broulik on Jun 23 2019, 9:07 AM.

Details

Reviewers

mvourlakos
ngraham
davidedmundson

Group Reviewers

Plasma

Commits

R120:52bec414aefa: [Notifications] Let plasmashell be the only true owner of notification and job…

Summary

Register notification and job tracker services with "allow replacement" flag if not plasmashell, so when it eventually comes up, it can claim the service and then cling on to it.

BUG: 408250
FIXED-IN: 5.16.2

Test Plan

Can't reproduce with latte but tried with plasmawindowed org.kde.plasma.notifications and then starting plasmashell

Not too happy about that magic property but other than that pretty cool imho

Diff Detail

Repository

R120 Plasma Workspace

Lint

Lint Skipped

Unit

Unit Tests Skipped

broulik created this revision.Jun 23 2019, 9:07 AM

Restricted Application added a project: Plasma. · View Herald TranscriptJun 23 2019, 9:07 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Jun 23 2019, 9:07 AM

ngraham added a reviewer: davidedmundson.Jun 23 2019, 9:17 AM

davidedmundson accepted this revision.Jun 23 2019, 3:49 PM

This revision is now accepted and ready to land.Jun 23 2019, 3:49 PM

Closed by commit R120:52bec414aefa: [Notifications] Let plasmashell be the only true owner of notification and job… (authored by broulik). · Explain WhyJun 23 2019, 4:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			libnotificationmanager/jobsmodel.h (3 lines)
M			libnotificationmanager/jobsmodel.cpp (2 lines)
M			libnotificationmanager/jobsmodel_p.h (2 lines)
M			libnotificationmanager/jobsmodel_p.cpp (41 lines)
M			libnotificationmanager/notificationsmodel.cpp (9 lines)
M			libnotificationmanager/server.h (5 lines)
M			libnotificationmanager/server.cpp (1 line)
M			libnotificationmanager/server_p.h (1 line)
M			libnotificationmanager/server_p.cpp (22 lines)
M			libnotificationmanager/utils.cpp (6 lines)
M			libnotificationmanager/utils_p.h (2 lines)
M			shell/main.cpp (3 lines)