Fix typos, improve wording and fix theming issues.
ClosedPublic

Authored by ognarb on Jun 23 2019, 8:57 AM.

Diff Detail

Repository
R935 Konsole Website
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Jun 23 2019, 8:57 AM
Restricted Application added a project: Konsole. · View Herald TranscriptJun 23 2019, 8:57 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
ognarb requested review of this revision.Jun 23 2019, 8:57 AM
ognarb edited the test plan for this revision. (Show Details)Jun 23 2019, 8:58 AM
ognarb added a reviewer: KDE Promo.
ngraham added inline comments.
users.md
23

For this, how about using the sub submission URL rather than the browsing URL?

https://bugs.kde.org/enter_bug.cgi?product=konsole

ognarb updated this revision to Diff 60428.Jun 23 2019, 9:36 AM

Fix typo and uses correct bugzilla url

ngraham accepted this revision.Jun 23 2019, 9:44 AM

Shipit!

This revision is now accepted and ready to land.Jun 23 2019, 9:44 AM

@bcooksley I also updated websites/jekyll-kde-theme, and created a new version. Could you rebuild the docker image? And in the future could it be possible to create a ci job, so that each time I push a new tag, the docker is rebuild? I don't want to disturb you each time.

The Docker image builds are already CI jobs, however they're manually triggered as it's usually pretty uncommon to need rapid changes in them.

Are you expecting to need many more changes in this Jekyll theme?

I've now initiated the rebuild.

The Docker image builds are already CI jobs, however they're manually triggered as it's usually pretty uncommon to need rapid changes in them.

Are you expecting to need many more changes in this Jekyll theme?

Hopefully not anymore :)

This revision was automatically updated to reflect the committed changes.