Details
Diff Detail
- Repository
- R262 LabPlot
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/backend/core/column/ColumnPrivate.cpp | ||
---|---|---|
903 | Ok. We can remove these comments. | |
904 | use range based for-loop here. | |
908 | this vector doesn't seem to be used. Maybe you can remove it as part of your next patch here. | |
962 | check indentation here. | |
966 | this check is obsolete since it must be always a Spreadsheet. You can add an assert here maybe. | |
src/backend/core/column/ColumnPrivate.h | ||
142 | QVector instead of QList. Not a big difference here, just a matter of convention in the code. | |
src/backend/spreadsheet/Spreadsheet.cpp | ||
676 ↗ | (On Diff #60390) | we allow to trigger this "Generate data from function values" also on integer columns. Since the results of the such calculations are floating point number usually, we convert here to Numeric. |
src/backend/spreadsheet/Spreadsheet.h | ||
72 ↗ | (On Diff #60390) | we can work with references here. |
src/kdefrontend/spreadsheet/FunctionValuesDialog.cpp | ||
367 | what happens now if m_spreadsheet->rowCount() < maxRowCount? | |
372 | You removed the usage of ExpressinParser here. We can remove the include "EvaluationParser.h" in this file, too. |
src/kdefrontend/spreadsheet/FunctionValuesDialog.cpp | ||
---|---|---|
367 | sorry is a mistake |