Fix problems when automatically recalcuating columns
ClosedPublic

Authored by Murmele on Jun 22 2019, 6:41 PM.

Diff Detail

Repository
R262 LabPlot
Lint
Lint Skipped
Unit
Unit Tests Skipped
Murmele created this revision.Jun 22 2019, 6:41 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJun 22 2019, 6:41 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
Murmele requested review of this revision.Jun 22 2019, 6:41 PM
sgerlach added inline comments.
src/backend/spreadsheet/Spreadsheet.cpp
676 ↗(On Diff #60398)

in english: "why?"

src/kdefrontend/spreadsheet/FunctionValuesDialog.cpp
363

to -> too

367

to -> too

asemke added inline comments.Jun 22 2019, 8:43 PM
src/backend/core/column/ColumnPrivate.cpp
903

Ok. We can remove these comments.

904

use range based for-loop here.

908

this vector doesn't seem to be used. Maybe you can remove it as part of your next patch here.

962

check indentation here.

966

this check is obsolete since it must be always a Spreadsheet. You can add an assert here maybe.

src/backend/core/column/ColumnPrivate.h
142

QVector instead of QList. Not a big difference here, just a matter of convention in the code.

src/backend/spreadsheet/Spreadsheet.cpp
676 ↗(On Diff #60398)

we allow to trigger this "Generate data from function values" also on integer columns. Since the results of the such calculations are floating point number usually, we convert here to Numeric.

src/backend/spreadsheet/Spreadsheet.h
72 ↗(On Diff #60398)

we can work with references here.

src/kdefrontend/spreadsheet/FunctionValuesDialog.cpp
367

what happens now if m_spreadsheet->rowCount() < maxRowCount?

372

You removed the usage of ExpressinParser here. We can remove the include "EvaluationParser.h" in this file, too.

Murmele marked 13 inline comments as done.Jun 22 2019, 9:08 PM
Murmele added inline comments.
src/kdefrontend/spreadsheet/FunctionValuesDialog.cpp
367

sorry is a mistake

Murmele updated this revision to Diff 60398.Jun 23 2019, 6:29 AM
Murmele marked an inline comment as done.
Murmele updated this revision to Diff 60414.Jun 23 2019, 7:40 AM
asemke accepted this revision.Jun 23 2019, 7:46 AM
This revision is now accepted and ready to land.Jun 23 2019, 7:46 AM
This revision was automatically updated to reflect the committed changes.