Differential D22000

[colors/Breeze] Change selected text color to black
AbandonedPublic
Actions

Authored by ndavis on Jun 22 2019, 2:43 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Breeze
Plasma
Maniphest Tasks
T11124: Unify highlight effect style
Summary

Also make black text color match the Shade Black color:

https://hig.kde.org/style/color/default.html

Depends on D21999

Test Plan

Before:

After, with necessary patches:

Diff Detail

Repository
R31 Breeze
Branch
breeze-selected-text (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13154
Build 13172: arc lint + arc unit
ndavis created this revision.Jun 22 2019, 2:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 22 2019, 2:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ndavis requested review of this revision.Jun 22 2019, 2:43 PM
ndavis retitled this revision from Change selected text color to black to [colors/Breeze] Change selected text color to black.Jun 22 2019, 2:50 PM
zzag added a subscriber: zzag.Jun 22 2019, 3:06 PM

Can you attach before & after screenshots?

ndavis edited the summary of this revision. (Show Details)Jun 22 2019, 3:10 PM
ndavis edited the test plan for this revision. (Show Details)
ngraham requested changes to this revision.Jun 22 2019, 3:11 PM
ngraham added subscribers: cfeck, ngraham.

This also needs to be changed in the Default theme here in the same repo, in the Kirigami repo (which has a duplicate of it) and in some Framework that I never remember (maybe @cfeck remembers).

This revision now requires changes to proceed.Jun 22 2019, 3:11 PM
ngraham edited the summary of this revision. (Show Details)Jun 22 2019, 3:11 PM
ngraham edited the test plan for this revision. (Show Details)
ndavis added a dependent revision: D22003: Change selected text color to black.Jun 22 2019, 3:31 PM
ndavis edited the summary of this revision. (Show Details)
IlyaBizyaev added a subscriber: IlyaBizyaev.Jun 22 2019, 3:36 PM

Looks fine in the menu, but black on bright blue in the list model below is just wrong now.

filipf added a subscriber: filipf.Jun 22 2019, 3:42 PM
In D22000#484409, @IlyaBizyaev wrote:

Looks fine in the menu, but black on bright blue in the list model below is just wrong now.

There would be no black on bright blue once the task is finished; that's one of the points - to not have white on bright blue.

ndavis added a comment.Jun 22 2019, 3:48 PM
In D22000#484409, @IlyaBizyaev wrote:

Looks fine in the menu, but black on bright blue in the list model below is just wrong now.

I don't actually have all the necessary patches right now, so pretend you don't see that.

ndavis abandoned this revision.Jul 15 2019, 12:47 PM

Abandoning because it can negatively affect other widget styles.

Revision Contents
Changeset List

PathPackages
Mcolors/Breeze.colors (14 lines)

Diff 60355

View Options

colors/Breeze.colors

Loading...