[WIP] Make highlights similar to Kickoff highlight
ClosedPublic

Authored by ndavis on Jun 22 2019, 1:46 PM.

Diff Detail

Repository
R31 Breeze
Branch
highlight (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13152
Build 13170: arc lint + arc unit
ndavis created this revision.Jun 22 2019, 1:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 22 2019, 1:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ndavis requested review of this revision.Jun 22 2019, 1:46 PM
ndavis edited the summary of this revision. (Show Details)Jun 22 2019, 1:48 PM
ndavis edited the test plan for this revision. (Show Details)
ndavis edited the summary of this revision. (Show Details)
ndavis retitled this revision from Make context menu highlight similar to Kickoff highlight to [WIP] Make context menu highlight similar to Kickoff highlight.Jun 22 2019, 2:00 PM

Looks amazing! But I think we need to do all the highlight effects at once. At least, all the ones that need to be done in this repo. Kirigami and qqc2-desktop-style will need their own patches, of course.

filipf added a subscriber: filipf.Jun 22 2019, 2:19 PM

Visually +100, obviously we can only merge it until we have changed it all places (+gtk theme).

ndavis updated this revision to Diff 60353.Jun 22 2019, 2:32 PM

Remove unnecessary if statement

ndavis retitled this revision from [WIP] Make context menu highlight similar to Kickoff highlight to [WIP] Make highlights similar to Kickoff highlight.Jun 23 2019, 1:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 23 2019, 2:28 PM
This revision was automatically updated to reflect the committed changes.
ngraham reopened this revision.Jun 23 2019, 3:36 PM

Not actually closed; Phab just failed to notice that this went to a WIP branch.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 23 2019, 4:21 PM
This revision was automatically updated to reflect the committed changes.

I guess we should just keep this revision closed due to arc sadness, and submit the final branch once it's all done.