Differential D21997

[placement] Avoid smart placement strategy with invalid client sizes
ClosedPublic
Actions

Authored by davidedmundson on Jun 22 2019, 1:11 PM.

Details

Reviewers
broulik
Group Reviewers
KWin
Commits
R108:842b2ce51b6b: [placement] Avoid smart placement strategy with invalid client sizes
Summary

To do so can in some situations lock up as the loop goes through
different positions incrementing by client->width/height.

If this is zero we can get into a stuck state.

This became a more common issue due to my earlier patch that places windows
in ShellClient::finishInit to allow the maximize placement strategy to
set the first configure size.

BUG: 408754

Diff Detail

Repository
R108 KWin
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 13148
Build 13166: arc lint + arc unit
davidedmundson created this revision.Jun 22 2019, 1:11 PM
Restricted Application added a project: KWin. · View Herald TranscriptJun 22 2019, 1:11 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jun 22 2019, 1:11 PM
broulik accepted this revision.Jun 24 2019, 8:02 PM
This revision is now accepted and ready to land.Jun 24 2019, 8:02 PM
Closed by commit R108:842b2ce51b6b: [placement] Avoid smart placement strategy with invalid client sizes (authored by davidedmundson). · Explain WhyJun 24 2019, 8:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mplacement.cpp (4 lines)

Diff 60344

View Options

placement.cpp

Loading...