Differential D21990

Don't propagate a title change if it didn't actually change
ClosedPublic
Actions

Authored by broulik on Jun 22 2019, 11:08 AM.

Details

Reviewers
fvogt
hein
Group Reviewers
Plasma
Commits
R856:97cd13a388f1: Don't propagate a title change if it didn't actually change
Summary

Noticed Telegram continuously touched the window title. The host didn't actually send a change on mpris but there was still some useless communication going on between content script and extension.

Test Plan

Didn't get that anymore. Genuine window title changes e.g. in spotify are still reflected fine on mpris

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 22 2019, 11:08 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 22 2019, 11:08 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 22 2019, 11:08 AM
hein accepted this revision.Jun 22 2019, 11:10 AM
hein added a subscriber: hein.

Ironically quite similar to a DDoS vector on the Task Manager. Apps suck :)

This revision is now accepted and ready to land.Jun 22 2019, 11:10 AM
Closed by commit R856:97cd13a388f1: Don't propagate a title change if it didn't actually change (authored by broulik). · Explain WhyJun 23 2019, 9:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mextension/content-script.js (4 lines)

Diff 60430

View Options

extension/content-script.js

Loading...