Differential D21989

Don't show error message if sharing is cancelled by the user
ClosedPublic
Actions

Authored by nicolasfella on Jun 22 2019, 10:55 AM.

Details

Reviewers
apol
ngraham
Commits
R495:a207a669815f: Don't show error message if sharing is cancelled by the user
Summary

Cancelling a share is usually intentional and should not result in a scary looking error message

Test Plan

Cancel a share from Dolphin, don't get an error message any more

Diff Detail

Repository
R495 Purpose Library
Branch
noerror
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13133
Build 13151: arc lint + arc unit
nicolasfella created this revision.Jun 22 2019, 10:55 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 22 2019, 10:55 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jun 22 2019, 10:55 AM
broulik added a subscriber: broulik.Jun 22 2019, 10:58 AM
broulik added inline comments.
src/fileitemactionplugin/sharefileitemaction.cpp
56

If possible use KIO::ERR_USER_CANCELED, otherwise don't bother, comment's fine

nicolasfella updated this revision to Diff 60321.Jun 22 2019, 11:07 AM
  • use KIO::ERR_USER_CANCELED
nicolasfella marked an inline comment as done.Jun 22 2019, 11:08 AM
ngraham accepted this revision.Jun 22 2019, 11:22 AM
This revision is now accepted and ready to land.Jun 22 2019, 11:22 AM
apol accepted this revision.Jun 22 2019, 1:53 PM
Closed by commit R495:a207a669815f: Don't show error message if sharing is cancelled by the user (authored by nicolasfella). · Explain WhyJun 22 2019, 1:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 60321

View Options

src/fileitemactionplugin/sharefileitemaction.cpp

Loading...
View Options

src/widgets/JobDialog.qml

Loading...
View Options

src/widgets/menu.h

Loading...