Differential D21983

[Kickoff/Dash] Show Calculator and Unit Converter runners
ClosedPublic
Actions

Authored by ngraham on Jun 22 2019, 9:03 AM.

Details

Reviewers
hein
filipf
Group Reviewers
VDG
Plasma
Commits
R119:16eddf0503ba: [Kickoff/Dash] Show Calculator and Unit Converter runners
Summary

The Calculator and Unit Converter runners are some of the most useful and
productivity-boosting runners, yet they don't show up in Kicker/Kickoff/Dash
right now, only in KRunner.

This patch makes them show up in Kickoff and Dash, increasing discoverability
and productivity for regular users who are less likely to know about KRunner's
standalone UI.

Kicker is excluded because its search UI was not designed for multiple runners
and that needs to be fixed first (https://bugs.kde.org/show_bug.cgi?id=389146)

CCBUG: 382760

Test Plan


Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jun 22 2019, 9:03 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 22 2019, 9:03 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jun 22 2019, 9:03 AM
filipf accepted this revision.Jun 22 2019, 9:11 AM
This revision is now accepted and ready to land.Jun 22 2019, 9:11 AM
hein added a comment.Jun 22 2019, 4:24 PM

Let's only do it for Kickoff and the Dash? The Kicker UI is really not made for arbitrary runners.

ngraham updated this revision to Diff 60374.Jun 22 2019, 4:29 PM

Don't do it for Kicker

ngraham edited the test plan for this revision. (Show Details)Jun 22 2019, 4:29 PM
hein added a comment.Jun 22 2019, 4:30 PM

You can do it for Dash, though -- check that isDash check where it already adds some runners to the Dash it doesn't add to App Menu.

I'm fine with doing it for Kicker later, but we need to resolve the design issue first so we don't create a new bug.

ngraham updated this revision to Diff 60375.Jun 22 2019, 4:31 PM

Do do it for Dash

hein accepted this revision.Jun 22 2019, 4:31 PM
ngraham retitled this revision from [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners to [Kickoff/Dash] Show Calculator and Unit Converter runners.Jun 22 2019, 4:33 PM
ngraham edited the summary of this revision. (Show Details)
Closed by commit R119:16eddf0503ba: [Kickoff/Dash] Show Calculator and Unit Converter runners (authored by ngraham). · Explain WhyJun 22 2019, 4:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 60377

View Options

applets/kicker/package/contents/ui/main.qml

Loading...
View Options

applets/kickoff/package/contents/ui/SearchView.qml

Loading...