Set SwipeListItem implicitHeight to be the maximum of content and actions
ClosedPublic

Authored by davidre on Sat, Jun 22, 8:34 AM.

Details

Summary

Otherwise if the content is smaller than the actions they will be partially
outside out of the item

Test Plan

Can be seen for example in virtual desktops kcm and slideshow configuation dialog

Before


After

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.Sat, Jun 22, 8:34 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptSat, Jun 22, 8:34 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidre requested review of this revision.Sat, Jun 22, 8:34 AM
ngraham accepted this revision.Sat, Jun 22, 8:36 AM
ngraham added reviewers: Kirigami, mart.
ngraham added subscribers: mart, ngraham.

LGTM. @mart?

This revision is now accepted and ready to land.Sat, Jun 22, 8:36 AM
davidre edited the test plan for this revision. (Show Details)Sat, Jun 22, 8:38 AM

Now that I look at it, the right-most button's right padding is also too high; it should be much closer to the right edge of the list item. Maybe good material for another patch.

mart accepted this revision.Sat, Jun 22, 10:19 AM
This revision was automatically updated to reflect the committed changes.