Julia backend: variable management
ClosedPublic

Authored by ivanlakhtanov on Jul 17 2016, 9:04 PM.

Details

Summary
  • Tracking of variables: adding, clearing, loading implemented
  • Syntax highlighter uses extracted functions and variables
  • Caching of modules variables

Diff Detail

Repository
R55 Cantor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ivanlakhtanov retitled this revision from to Julia backend: variable management.
ivanlakhtanov updated this object.
ivanlakhtanov edited the test plan for this revision. (Show Details)
ivanlakhtanov set the repository for this revision to R55 Cantor.
ivanlakhtanov added a project: Cantor.
ivanlakhtanov added a subscriber: Cantor.
ivanlakhtanov updated this object.
filipesaraiva edited edge metadata.Aug 20 2016, 3:08 PM

@ivanlakhtanov, please could you confirm if the feature works just using this patch? I applied it, I can see the variable management widget but when I create a variable in the worksheet (like typing and running x = 3), Cantor starts the command processing but never stop.

@ivanlakhtanov, please could you confirm if the feature works just using this patch? I applied it, I can see the variable management widget but when I create a variable in the worksheet (like typing and running x = 3), Cantor starts the command processing but never stop.

I have checkouted to Variable management commit and everything works fine. I can take this on video if you don't belive me. Can you try to run unit-tests for command execution? And are you sure you have added all dependent patches like latest command execution?

Question: can I push --force to own remote feature branch? That way I can send it to server, so you can checkout to desired commit.

@ivanlakhtanov, please could you confirm if the feature works just using this patch? I applied it, I can see the variable management widget but when I create a variable in the worksheet (like typing and running x = 3), Cantor starts the command processing but never stop.

I have checkouted to Variable management commit and everything works fine. I can take this on video if you don't belive me. Can you try to run unit-tests for command execution? And are you sure you have added all dependent patches like latest command execution?

Question: can I push --force to own remote feature branch? That way I can send it to server, so you can checkout to desired commit.

Have just checked it with arc patch D2198. Everything is OK. Which version of Julia do you have?

Ok, I found the problem. It was just the path to julia bin was incorrect, now it is working properly.

filipesaraiva requested changes to this revision.Aug 20 2016, 6:55 PM
filipesaraiva edited edge metadata.
filipesaraiva added inline comments.
src/backends/julia/julia.qrc
6–10 ↗(On Diff #5959)

Ok, like the previous review request, remove this qrc file. Use the same approach of Octave backend: create a script folder, put your scripts there and create a new CMakeLists.txt file in the folder.

src/backends/julia/juliaextensions.cpp
59–73

After remove that QRC file you must to change those calls of fromSource.

src/backends/julia/juliautils.h
1–29 ↗(On Diff #5959)

Does this header get more functions in the other patches? If not maybe you could to change the name for something more specific like "loadScripts".

This revision now requires changes to proceed.Aug 20 2016, 6:55 PM
ivanlakhtanov edited edge metadata.

Moved from QtResources and gathered scripts in separate folder

filipesaraiva accepted this revision.Aug 21 2016, 3:55 AM
filipesaraiva edited edge metadata.
This revision is now accepted and ready to land.Aug 21 2016, 3:55 AM
This revision was automatically updated to reflect the committed changes.
ivanlakhtanov marked an inline comment as done.