Differential D21969

Remove qtquickcontrols dir
ClosedPublic
Actions

Authored by ndavis on Jun 21 2019, 3:40 PM.

Details

Reviewers

Group Reviewers

Breeze
Plasma

Commits

R31:49c5b6966ecd: Remove qtquickcontrols dir
R31:85bcb9dd1d3d: Remove qtquickcontrols dir

Summary

@mart said these files are no longer used, so I'm removing them.

Diff Detail

Repository

R31 Breeze

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ndavis created this revision.Jun 21 2019, 3:40 PM

Restricted Application added a project: Plasma. · View Herald TranscriptJun 21 2019, 3:40 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ndavis requested review of this revision.Jun 21 2019, 3:40 PM

Harbormaster completed remote builds in B13095: Diff 60253.Jun 21 2019, 3:40 PM

ndavis edited the summary of this revision. (Show Details)Jun 21 2019, 3:42 PM

ndavis added a reviewer: mart.

ndavis added a subscriber: mart.

ndavis edited reviewers, added: Plasma; removed: mart.Jun 21 2019, 5:29 PM

Super long term I think we do want to have this, with the desktop-style widget wrapper being only a fallback.

But we can always restore from history and even if we did want to use them it needs porting to QQC2.

This revision is now accepted and ready to land.Jun 28 2019, 11:34 AM

In D21969#487596, @davidedmundson wrote:

Super long term I think we do want to have this, with the desktop-style widget wrapper being only a fallback.

But we can always restore from history and even if we did want to use them it needs porting to QQC2.

Unless this mess is fixed in Qt 6 ;)

Closed by commit R31:49c5b6966ecd: Remove qtquickcontrols dir (authored by ndavis). · Explain WhyJun 28 2019, 7:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (1 line)
D	M	qtquickcontrols/ApplicationWindowStyle.qml (5 lines)
D	M	qtquickcontrols/Breeze.qml (59 lines)
D	M	qtquickcontrols/Breeze.qmlproject (20 lines)
D	M	qtquickcontrols/BusyIndicatorStyle.qml (47 lines)
D	M	qtquickcontrols/ButtonStyle.qml (58 lines)
D	M	qtquickcontrols/CMakeLists.txt (4 lines)
D	M	qtquickcontrols/CheckBoxIndicator.qml (105 lines)
D	M	qtquickcontrols/CheckBoxStyle.qml (30 lines)
D	M	qtquickcontrols/ColorUtils.js (9 lines)
D	M	qtquickcontrols/ComboBoxStyle.qml (76 lines)
D	M	qtquickcontrols/DemoPage1.qml (126 lines)
D	M	qtquickcontrols/DemoPage2.qml (118 lines)
D	M	qtquickcontrols/DemoPage3.qml (85 lines)
D	M	qtquickcontrols/DemoPage4.qml (37 lines)
D	M	qtquickcontrols/FocusFrameStyle.qml (6 lines)
D	M	qtquickcontrols/GroupBoxStyle.qml (108 lines)
D	M	qtquickcontrols/MenuBarStyle.qml (38 lines)
D	M	qtquickcontrols/MenuStyle.qml (165 lines)
D	M	qtquickcontrols/ProgressBarStyle.qml (70 lines)
D	M	qtquickcontrols/RadioButtonIndicator.qml (103 lines)
D	M	qtquickcontrols/RadioButtonStyle.qml (35 lines)
D	M	qtquickcontrols/ScrollArrow.qml (44 lines)
D	M	qtquickcontrols/ScrollBar.qml (58 lines)
D	M	qtquickcontrols/ScrollViewStyle.qml (33 lines)
D	M	qtquickcontrols/SliderStyle.qml (61 lines)
D	M	qtquickcontrols/SpinBoxStyle.qml (21 lines)
D	M	qtquickcontrols/StatusBarStyle.qml (19 lines)
D	M	qtquickcontrols/SwitchStyle.qml (33 lines)
D	M	qtquickcontrols/TabViewStyle.qml (55 lines)
D	M	qtquickcontrols/TableViewStyle.qml (93 lines)
D	M	qtquickcontrols/TextAreaStyle.qml (52 lines)
D	M	qtquickcontrols/TextFieldBackground.qml (13 lines)
D	M	qtquickcontrols/TextFieldStyle.qml (7 lines)
D	M	qtquickcontrols/ToolBarStyle.qml (18 lines)
D	M	qtquickcontrols/ToolButtonStyle.qml (61 lines)
D	M	qtquickcontrols/Triangle.qml (38 lines)
D	M	qtquickcontrols/qmldir (21 lines)