Differential D21965

Avoid crash without XWayland
ClosedPublic
Actions

Authored by davidedmundson on Jun 21 2019, 1:28 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:515f3cbb4e71: Avoid crash without XWayland
R108:3e428d33885a: Merge branch 'Plasma/5.16'
Summary

readX11ShadowProperty fails without an X connection

Test Plan

Tested by Kai who didn't have xwayland

Diff Detail

Repository
R108 KWin
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 13160
Build 13178: arc lint + arc unit
davidedmundson created this revision.Jun 21 2019, 1:28 PM
Restricted Application added a project: KWin. · View Herald TranscriptJun 21 2019, 1:28 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jun 21 2019, 1:28 PM
zzag added a subscriber: zzag.Jun 21 2019, 1:51 PM
zzag added inline comments.
shadow.cpp
127

It's a typo, right?

359

What's the id of the Toplevel?

zzag added inline comments.Jun 22 2019, 2:59 PM
shadow.cpp
127

... I think it should be XCB_WINDOW_NONE. That way we won't need to check the operation mode.

davidedmundson added a comment.Jun 22 2019, 3:16 PM

Aye, I forwarded a patch doing that to the person with the crash yesterday.

I haven't heard back. I couldn't easily reproduce myself.

davidedmundson updated this revision to Diff 60365.Jun 22 2019, 3:35 PM

Testing done

David: can you test https://phabricator.kde.org/P414 please
Kai: works

zzag accepted this revision.Jun 22 2019, 4:05 PM

Vlad: ship it

This revision is now accepted and ready to land.Jun 22 2019, 4:05 PM
Closed by commit R108:515f3cbb4e71: Avoid crash without XWayland (authored by davidedmundson). · Explain WhyJun 23 2019, 3:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshadow.cpp (2 lines)

Diff 60365

View Options

shadow.cpp

Loading...