Keep Klipper notifications out of notification history
ClosedPublic

Authored by broulik on Jun 21 2019, 12:43 PM.

Details

Summary

This makes Klipper identify as org.kde.klipper to the notification service even when running inside of Plasma and installs a rule to disable it from history by default.

BUG: 408989
FIXED-IN: 5.16.2

Test Plan

Since the desktop file is only shown outside of KDE, it doesn't show in the KCM and as such cannot be changed but I think having its contents not added to history makes sense from a privacy POV.

Maybe we need to introduce a new flag in KNotification, too, or have klipper have a proper notifyrc rather than using generic events or some other solution but this is good enough™ for stable.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 21 2019, 12:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 21 2019, 12:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 21 2019, 12:43 PM
davidedmundson accepted this revision.Jul 4 2019, 1:18 PM
This revision is now accepted and ready to land.Jul 4 2019, 1:18 PM
This revision was automatically updated to reflect the committed changes.