Differential D21956

Move class ColorOptionParser into separate file
AbandonedPublic
Actions

Authored by aspotashev on Jun 21 2019, 10:25 AM.

Details

Reviewers

Summary

Exclude ColorOptionParser from being pulled by __init__.py because this
class is not an essential part of Pology, just a helper for command line
tools.

Test Plan

'posieve find-messages ...' still works.

Diff Detail

Repository

R1046 Pology

Branch

move-coloroptparser

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13068
Build 13086: arc lint + arc unit

aspotashev requested review of this revision.Jun 21 2019, 10:25 AM

aspotashev created this revision.

Harbormaster completed remote builds in B13068: Diff 60209.Jun 21 2019, 10:25 AM

I don't agree that ColorOptionParser should not be part of Pology public API. Someone might want to write a custom command that uses Pology, without contributing it Pology repository. Or, in other words, if ColorString is part of API and returned by Pology's Gettext wrappers, then ColorOptionParser should be too.

aspotashev abandoned this revision.Jul 15 2019, 2:57 AM

Revision Contents
Changeset List

		Path
M		lang/es/scripts/createProperWordsDict.py (2 lines)
M		lang/sr/scripts/pohybdl.py (2 lines)
M		lang/sr/scripts/traplint.py (2 lines)
A	M	pology/coloroptparse.py (42 lines)
M		pology/colors.py (30 lines)
M		scripts/poascribe.py (3 lines)
M		scripts/poediff.py (3 lines)
M		scripts/poepatch.py (2 lines)
M		scripts/pomtrans.py (2 lines)
M		scripts/porewrap.py (2 lines)
M		scripts/poselfmerge.py (2 lines)
M		scripts/posieve.py (3 lines)
M		scripts/posummit.py (2 lines)