I originally didn't consider this neccessary because we have a qMessageHandler, so every qDebug goes through the proper formatting. However, if an external application is launched, it might blatantly print to stdout.
Details
Details
- Reviewers
davidedmundson fvogt - Group Reviewers
Plasma - Commits
- R856:ee36561ca66f: Ensure no one but us writes to stdout
- Triggered Purpose menu from a website, chose "send via email" which triggered Thunderbird and then quit Thunderbird. Previously the host was killed by printing
*** UTM:SVC TimerManager:registerTimer called after profile-before-change notification. Ignoring timer registration for id: telemetry_modules_ping
on stdout. Now the host continues to run smoothly. Everything else is unaffected
Diff Detail
Diff Detail
- Repository
- R856 Plasma Browser Integration
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| host/connection.cpp | ||
|---|---|---|
| 39 | I'd dup2(STDERR_FILENO, STDOUT_FILENO); instead to ensure that if something tries to write to it or query something, there aren't unexpected errors. | |