Differential D21910

Preferences dialog is resized from its default size, such that the complete content is visible.
Needs RevisionPublic
Actions

Authored by mayankchoudhary on Jun 19 2019, 4:55 PM.

Details

Reviewers
ngraham
Group Reviewers
Okular
Summary

Preferences dialog have pages like "General" and "Presentation" where the user need to scroll down in order to see all the options. It would be nice to see all the contents without scrolling to make it easy for user to find out all options,

BUG: 397678

Test Plan
  1. Open Okular
  2. Go to Settings -> Configure Okular...
  3. The Preferences Dialog will open where the contents of "General" and "Presentation" pages need to be scrolled to find out all the options
  4. Now using this patch, you can find the resized dialog where all the options are visible without scrolling

Diff Detail

Repository
R223 Okular
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12981
Build 12999: arc lint + arc unit
Restricted Application added a project: Okular. · View Herald TranscriptJun 19 2019, 4:55 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
mayankchoudhary requested review of this revision.Jun 19 2019, 4:55 PM
ngraham requested changes to this revision.Jun 19 2019, 5:38 PM
ngraham added a subscriber: ngraham.

While this sort of works, now it makes the dialog way too tall, and I don't think it's the right approach to the problem. We should figure out what's causing the default size to be wrong and fix that, rather than leaving it broken and working around it in the proposed way.

This revision now requires changes to proceed.Jun 19 2019, 5:38 PM
ngraham edited the summary of this revision. (Show Details)Jun 19 2019, 5:39 PM
ngraham added a reviewer: Okular.
mayankchoudhary added a comment.Jun 20 2019, 4:45 AM

We get default size because of kconfigdialog. If we make changes in kconfigdialog, all the Dialogs sizes will be changed.

ngraham added a comment.Jun 20 2019, 6:28 AM

If KConfigDialog is calculating default window sizes incorrectly under certain circumstances, then it probably should be changed. :)

mayankchoudhary added a comment.Jun 21 2019, 7:59 AM

what to do? Is it still a junior job now?

ngraham added a comment.Jun 21 2019, 9:47 AM

Figure out why the default size is incorrectly calculated and fix it. :)

Revision Contents
Changeset List

PathPackages
Mconf/preferencesdialog.cpp (1 line)

Diff 60078

View Options

conf/preferencesdialog.cpp

Loading...