Differential D21908

Possible fix for the blur effect on Intel
ClosedPublic
Actions

Authored by fredrik on Jun 19 2019, 4:40 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Summary

Prefer an sRGB capable fbconfig for the default framebuffer.

BUG: 408594

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
fredrik created this revision.Jun 19 2019, 4:40 PM
Restricted Application added a project: KWin. · View Herald TranscriptJun 19 2019, 4:40 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
fredrik requested review of this revision.Jun 19 2019, 4:40 PM
ngraham edited the summary of this revision. (Show Details)Jun 19 2019, 4:47 PM
zzag accepted this revision.Jun 19 2019, 4:58 PM
zzag added a subscriber: zzag.

It works.

This revision is now accepted and ready to land.Jun 19 2019, 4:58 PM
sbergeron added a comment.EditedJun 19 2019, 5:04 PM

Is the code here common between X11 and Wayland sessions? Or is there other code involved for Wayland that needs to be addressed separately? 408594 is reproduceable for me on Wayland as well as X11, which is why I ask.

EDIT: a user on the bug report confirmed this works on X11 but the bug is still present on Wayland session, feel free to disregard the original question

fredrik added a comment.Jun 19 2019, 11:24 PM
In D21908#482053, @sbergeron wrote:

Is the code here common between X11 and Wayland sessions? Or is there other code involved for Wayland that needs to be addressed separately? 408594 is reproduceable for me on Wayland as well as X11, which is why I ask.

EDIT: a user on the bug report confirmed this works on X11 but the bug is still present on Wayland session, feel free to disregard the original question

Yeah, I somehow had the idea that we always use GLES on Wayland, which would have made it unaffected by the bug.
It will need a similar patch.

ngraham added a subscriber: ngraham.Jun 20 2019, 7:30 AM
In D21908#482152, @fredrik wrote:

Yeah, I somehow had the idea that we always use GLES on Wayland, which would have made it unaffected by the bug.
It will need a similar patch.

Does D21916 take care of it, or is that patch for something else?

fredrik added a comment.Jun 20 2019, 10:50 AM
In D21908#482184, @ngraham wrote:
In D21908#482152, @fredrik wrote:

Yeah, I somehow had the idea that we always use GLES on Wayland, which would have made it unaffected by the bug.
It will need a similar patch.

Does D21916 take care of it, or is that patch for something else?

Yeah, that should fix it.

fredrik closed this revision.Jun 29 2019, 4:33 PM

To ssh://git.kde.org/kwin
61956025f..3d384f3c9 Plasma/5.16 -> Plasma/5.16

Revision Contents
Changeset List

Diff 60074

View Options

plugins/platforms/x11/standalone/glxbackend.cpp

Loading...