fix restore of tracks with missing metadata in playlist
ClosedPublic

Authored by mgallien on Jun 19 2019, 3:26 PM.

Details

Summary

fix storing of tracks without track, disc, ...

correctly store a null when track, disc, channels, bit rate, sample rate
are not existing in the track data

will need a complete reindexing to fix users database

let play list and audio player restore state when track has few metadata

when album, track number or disc number are missing, the state is not
correctly restored at startup

let those metadata be optional in the saved state such that tracks
missing those are still restored

Test Plan

new test is OK and a track without album, track and disc numbers will restore and playback will restore at correct position

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.Jun 19 2019, 3:26 PM
mgallien created this revision.
astippich accepted this revision.Jun 24 2019, 3:23 PM
astippich added a subscriber: astippich.

Eventually, all metadata should be optional...
I think for database insertion the track title is still the only one that is a hard requirement, but this should also be removed.

This revision is now accepted and ready to land.Jun 24 2019, 3:23 PM
This revision was automatically updated to reflect the committed changes.