print a warning when invoking the scripting API's sleep()
ClosedPublic

Authored by sitter on Jun 19 2019, 9:40 AM.

Details

Summary

the sleep is implemented with a nested event loop which may result in
segfaults when something in the new loop stack accesses objects from the
original loop stack that are presently in a bad state because they were
not meant to be accessed (and only can because of the nesting).

to aid in debugging let's leave a trace of the fact that sleep was used
when in fact, using sleep is super risky.

Test Plan

warning gets printed when sleeping

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jun 19 2019, 9:40 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 19 2019, 9:40 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jun 19 2019, 9:40 AM

Why does this even exist?

Legacy from Plasma1 I'd guess. We could make it noop and drop it for 6.x IMO, I'm not sure if we want to change behavior halfway though 5.x though.

mart accepted this revision.Jun 20 2019, 1:53 PM

we could make it a no op even?

This revision is now accepted and ready to land.Jun 20 2019, 1:53 PM
This revision was automatically updated to reflect the committed changes.