diff --git a/libk3b/jobs/k3bdvdcopyjob.cpp b/libk3b/jobs/k3bdvdcopyjob.cpp --- a/libk3b/jobs/k3bdvdcopyjob.cpp +++ b/libk3b/jobs/k3bdvdcopyjob.cpp @@ -253,6 +253,7 @@ } } } + Q_FALLTHROUGH(); case K3b::Device::MEDIA_DVD_R: case K3b::Device::MEDIA_DVD_R_SEQ: case K3b::Device::MEDIA_DVD_RW: diff --git a/libk3b/projects/datacd/k3bisoimager.cpp b/libk3b/projects/datacd/k3bisoimager.cpp --- a/libk3b/projects/datacd/k3bisoimager.cpp +++ b/libk3b/projects/datacd/k3bisoimager.cpp @@ -163,7 +163,7 @@ break; } - // otherwise just fall through + Q_FALLTHROUGH(); default: if( !d->knownError && !mkisofsReadError() ) { diff --git a/libk3bdevice/k3bdevice.cpp b/libk3bdevice/k3bdevice.cpp --- a/libk3bdevice/k3bdevice.cpp +++ b/libk3bdevice/k3bdevice.cpp @@ -2130,6 +2130,7 @@ // done. break; } + Q_FALLTHROUGH(); default: case MEDIA_CD_ROM: @@ -2153,6 +2154,7 @@ inf.d->usedCapacity = readToc().length(); } } + break; case MEDIA_DVD_ROM: { K3b::Msf readCap; @@ -2238,6 +2240,7 @@ case MEDIA_DVD_RW_OVWR: inf.d->numSessions = 1; + Q_FALLTHROUGH(); case MEDIA_DVD_RW: case MEDIA_DVD_RW_SEQ: // only one track on a DVD-RW media diff --git a/src/k3b.cpp b/src/k3b.cpp --- a/src/k3b.cpp +++ b/src/k3b.cpp @@ -904,8 +904,7 @@ KStandardGuiItem::save(), KStandardGuiItem::dontSave() ) ) { case KMessageBox::Yes: - if ( !fileSave( doc ) ) - return false; + return fileSave( doc ); case KMessageBox::No: return true; default: diff --git a/src/k3bprojectmanager.cpp b/src/k3bprojectmanager.cpp --- a/src/k3bprojectmanager.cpp +++ b/src/k3bprojectmanager.cpp @@ -337,7 +337,8 @@ movixDoc->setEjectDisk( c.readEntry( "eject", false ) ); movixDoc->setRandomPlay( c.readEntry( "random_play", false ) ); movixDoc->setNoDma( c.readEntry( "no_dma", false ) ); - // fallthrough + + Q_FALLTHROUGH(); } case K3b::Doc::DataProject: { diff --git a/src/projects/k3baudioprojectmodel.cpp b/src/projects/k3baudioprojectmodel.cpp --- a/src/projects/k3baudioprojectmodel.cpp +++ b/src/projects/k3baudioprojectmodel.cpp @@ -269,8 +269,8 @@ f.setPointSize( f.pointSize() - 2 ); return f; } - break; } + break; case Qt::ForegroundRole: if ( index.column() == FilenameColumn ) { diff --git a/src/projects/k3bdataurladdingdialog.cpp b/src/projects/k3bdataurladdingdialog.cpp --- a/src/projects/k3bdataurladdingdialog.cpp +++ b/src/projects/k3bdataurladdingdialog.cpp @@ -473,6 +473,7 @@ break; case 4: m_bFolderLinksAddAll = true; + Q_FALLTHROUGH(); case 3: followLink = false; break; diff --git a/src/projects/kostore/KoStore.cpp b/src/projects/kostore/KoStore.cpp --- a/src/projects/kostore/KoStore.cpp +++ b/src/projects/kostore/KoStore.cpp @@ -127,6 +127,7 @@ case Directory: qCCritical(KOSTORE) << "Can't create a Directory store for a memory buffer!" << endl; // fallback + Q_FALLTHROUGH(); case Zip: #ifdef QCA2 if( automatic && mode == Read ) { diff --git a/src/rip/k3baudiotrackmodel.cpp b/src/rip/k3baudiotrackmodel.cpp --- a/src/rip/k3baudiotrackmodel.cpp +++ b/src/rip/k3baudiotrackmodel.cpp @@ -345,6 +345,7 @@ emit dataChanged( index, index ); return true; } + break; case Qt::CheckStateRole: setTrackChecked( index.row(), value.toInt() == Qt::Checked );