Simplify QApplication created to wrap test GLContext.

Authored by davidedmundson on Jun 18 2019, 8:08 PM.



In order to create the correct GLContext Krita has to create a
GLContext. This requires the QPA to be connected and a QGuiApplication.

However, this doesn't require loading styles and most importantly the
QPlatformTheme. Loading this multiple times within a process is somewhat
questionable and seems to cause issues with the Plasma QPT. Skipping it
should make things noticably faster too.

BUG: 408015

Test Plan

GDB on krita.
I haven't tested the conditions of the bug and I'm not a krita user. So I would
appreciate someone else doing so.

Diff Detail

R37 Krita
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jun 18 2019, 8:08 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptJun 18 2019, 8:08 PM
Restricted Application added a project: Krita. · View Herald Transcript
davidedmundson requested review of this revision.Jun 18 2019, 8:08 PM
rempt accepted this revision.Jun 20 2019, 8:07 AM
This revision is now accepted and ready to land.Jun 20 2019, 8:07 AM
rempt added a comment.Jun 20 2019, 8:08 AM

Yes, this works :-)

I'm away at a sprint without my git checkout of krita and poor internet.

I just saw your release announcement email, if you'd like this patch for the next release (which is entirely up to you) please can you land it for me.


This revision was automatically updated to reflect the committed changes.