Fix detection of recommendation about DAO mode from growisofs

Authored by volkov on Jun 18 2019, 12:09 PM.



Fast blanked DVD-RW can only be burned in DAO mode. Some DVD drives
can't detect whether DVD-RW is fast or fully blanked, and the only
way to know it is from the error message from growisofs.

Currently k3b shows very uninformative message:
"Fatal error during recording: Input/output error".
This is because the output of growisofs is not parsed correctly.
First of all, stderr output is lost when growisofs is finished,
because K3b::ActivePipe closes the corresponding K3b::Process.
This is fixed by separating stderr and stdout channels of
growisofs. Secondly, the existing code assumes that the message
starts with ":-[", while it actually starts with ":-(".

Probably the bug was introduced 10 years ago by the commit

Diff Detail

R467 K3b
No Linters Available
No Unit Test Coverage
Build Status
Buildable 12945
Build 12963: arc lint + arc unit
volkov requested review of this revision.Jun 18 2019, 12:09 PM
volkov created this revision.
aacid added a subscriber: aacid.Jun 20 2019, 7:24 PM

Would it make sense to have it both in :-( and :-[ ?

Maybe the output has changed? (parsing output that isn't really supposed to be parsed is terrible)

The last release of dvd+rw-tools was made in 2008, and dvd+rw-format printed :-( even then.

This revision is now accepted and ready to land.Jun 24 2019, 8:19 AM
volkov closed this revision.Jun 24 2019, 10:11 AM