Add KInfoCenter module for Support Information
AbandonedPublic

Authored by broulik on Jun 17 2019, 1:47 PM.

Details

Reviewers
None
Group Reviewers
Plasma
VDG
KWin
Summary

It's a lot easier to remember telling people to do "KInfoCenter → Graphical Information → KWin Support information" than remembering the dbus service path.

Test Plan

(Alternatively we could add a kwin_x11 --support-information commandline argument that prints it out)



Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jun 17 2019, 1:47 PM
Restricted Application added a project: KWin. · View Herald TranscriptJun 17 2019, 1:47 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
broulik requested review of this revision.Jun 17 2019, 1:47 PM
broulik updated this revision to Diff 59996.

Set save mode for file dialog

broulik updated this revision to Diff 59997.Jun 17 2019, 1:48 PM
broulik edited the test plan for this revision. (Show Details)
  • Disable text field while loading/on error
broulik added inline comments.Jun 17 2019, 3:53 PM
kcmkwin/supportinformation/CMakeLists.txt
2

Will fix

broulik updated this revision to Diff 60016.Jun 18 2019, 10:54 AM
  • Fix translation domain
zzag added a subscriber: zzag.Jun 18 2019, 11:35 AM

Hmm, this means more code to maintain. I'm personally totally fine with using qdbus. qdbus org.kde.KWin /KWin supportInformation | xclip -sel clip or qdbus org.kde.KWin /KWin supportInformation > pizza.txt is not great, but not terrible.

Can we at least have a cmdline arg in kwin_x11 at least? I certainly don't want to look up the dbus path every time I see a KWin bug report..

zzag added a comment.Jun 18 2019, 12:20 PM

To be honest, I don't see why we need that option. The qdbus command is long, but not that long to introduce a shortcut.

We can add an alias, sure.
But we're not the intended user of the supportInformation. The person on the end of the bugzilla ticket is.

But we will be the one asking the user to type that command. So I either have to remember it or look it up (or use some macro or wahtever)

zzag added a comment.Jun 18 2019, 2:39 PM

I either have to remember it or look it up

Yep, that's pretty much it. We could however add relevant information to https://community.kde.org/KWin/Bugzilla.

But we will be the one asking the user to type that command. So I either have to remember it or look it up (or use some macro or wahtever)

That's really the crux of this. I think it's much easier and more user-friendly to ask the user to look up something in KInfoCenter than it is to ask them to use a terminal command, and for us to remember it.

+1 for the original goal.

broulik abandoned this revision.Sep 16 2019, 10:26 AM

Looks like I'm going to have to keep remembering obscure commands

I still think this is a great idea.

I keep running into the need for this. Can you re-open it? I think it would be very worthwhile to add.

bam added a subscriber: bam.Feb 10 2021, 9:48 PM