Translate keyboard layouts in sddm
Needs ReviewPublic

Authored by McPain on Jun 17 2019, 9:56 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
McPain created this revision.Jun 17 2019, 9:56 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 17 2019, 9:56 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
McPain requested review of this revision.Jun 17 2019, 9:56 AM
McPain added a reviewer: ngraham.

It might be better to do it in

XkbKeyboardBackend.cpp:184 in SDDM which is where the model comes from.

It might be better to do it in

XkbKeyboardBackend.cpp:184 in SDDM which is where the model comes from.

I don't see any matching files in sddm

It might be better to do it in

XkbKeyboardBackend.cpp:184 in SDDM which is where the model comes from.

I don't see any matching files in sddm

https://github.com/sddm/sddm/blob/develop/src/greeter/XcbKeyboardBackend.cpp

It might be better to do it in

XkbKeyboardBackend.cpp:184 in SDDM which is where the model comes from.

I don't see any matching files in sddm

https://github.com/sddm/sddm/blob/develop/src/greeter/XcbKeyboardBackend.cpp

thanks, but how should I do this?
These translations doesn't belong to sddm

These translations doesn't belong to sddm

why do they belong here and not SDDM?

These translations doesn't belong to sddm

why do they belong here and not SDDM?

Searching for the translation catalog name shows that it is managed by freedesktop.org [1]. So neither KDE, nor SDDM.

[1] https://github.com/freedesktop/xkeyboard-config/tree/master/po

So is this unnecessary, and the string should be translated somewhere over in FreeDesktop-land?

So is this unnecessary, and the string should be translated somewhere over in FreeDesktop-land?

The translations are done somewhere over in freedesktop-land, but someone still needs to load them.

This does it in our theme.
My question is why is this better than doing it in the SDDM model so that it "just works" for all themes.