Differential D21871

Check Postgres status by checking return code of pg_ctl
ClosedPublic
Actions

Authored by dvratil on Jun 17 2019, 8:42 AM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Commits
R165:565700f7fc1d: Check Postgres status by checking return code of pg_ctl
Summary

The current code which was checking the standard output of "pg_ctl status",
doesn't work with non-English locale, causing Akonadi to leave Postgres
running after shutdown, because it thinks the db is no longer running.

BUG: 386173
FIXED-IN: 5.11.3

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.Jun 17 2019, 8:42 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJun 17 2019, 8:42 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dvratil requested review of this revision.Jun 17 2019, 8:42 AM
dvratil edited the summary of this revision. (Show Details)Jun 17 2019, 8:58 AM
mlaurent accepted this revision.Jun 19 2019, 5:52 PM
mlaurent added a subscriber: mlaurent.

indeed it seems better to use an exitcode here:)

This revision is now accepted and ready to land.Jun 19 2019, 5:52 PM
Closed by commit R165:565700f7fc1d: Check Postgres status by checking return code of pg_ctl (authored by dvratil). · Explain WhyJun 20 2019, 9:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 60103

View Options

src/server/storage/dbconfigpostgresql.cpp

Loading...