Levene Test Implementaion
ClosedPublic

Authored by devanshuagarwal on Jun 16 2019, 5:51 PM.

Details

Reviewers
sgerlach
asemke
Summary

Hello Sir,

I have tried to implement Levene test for checking homogeneity condition.

I have also changed "findStatsCategorical" function in "HypothesisTest.cpp" to give stats for any number of categorical variables (not just two).

I have also added the functionality to let the user choose column whose column mode is not AbstractColumn::Text as an independent variable (containing class labels).

Similarly Levene test can be performed with any number of classes.

Test Plan

Levene Test pushbutton will appear for Two Sample Independent T-test and it will show the output like other normal tests.

Diff Detail

Repository
R262 LabPlot
Lint
Lint Skipped
Unit
Unit Tests Skipped
Restricted Application added a project: KDE Edu. · View Herald TranscriptJun 16 2019, 5:51 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
devanshuagarwal requested review of this revision.Jun 16 2019, 5:51 PM
  1. Removed switch case warnings.
  2. Removed old style case warning
  3. Changed QOverload to static_cast to support previous versions.
sgerlach added inline comments.Jun 18 2019, 8:33 PM
src/backend/hypothesis_test/HypothesisTest.cpp
232

please translate all user visible messages

239

better use "iter" or "nameIter". "i" should be only for counting integer.

470

Do you really use global vars? Please avoid this and make this function obsolete.

473

translate

484

at least + translate

525

use "/="

532

fabs() ?

614

"/="

617

"/="

670

translation (2x)

679

translation

682

translation

764

Column* column

src/backend/hypothesis_test/HypothesisTest.h
67

can you use camelCase for all variables? Just to make the naming style more consistent. I should have mentioned that before...

src/backend/hypothesis_test/HypothesisTestPrivate.h
42

better "HypothesisTestType"?

43

better "HypothesisErrorType"?

devanshuagarwal marked 16 inline comments as done.Aug 11 2019, 3:25 PM
devanshuagarwal marked 2 inline comments as not done.Aug 11 2019, 6:49 PM
devanshuagarwal added inline comments.
src/backend/hypothesis_test/HypothesisTestPrivate.h
42

I dont think that. Because whenever, we will be using TestType for HypothesisTest in some other class we will have to implement it using

HypothesisTest::TestType.

so, I dont think we need to explicitly add Hypothesis Term in TestType variable.

43

s.a.

sgerlach accepted this revision.Aug 13 2019, 10:18 AM

Done.

src/backend/hypothesis_test/HypothesisTestPrivate.h
42

ok. Makes sense.

43

s.a.

This revision is now accepted and ready to land.Aug 13 2019, 10:18 AM
sgerlach closed this revision.Aug 18 2019, 10:01 PM