Differential D21856

[Task manager] Use consistent menu items for "pin/unpin" actions
ClosedPublic
Actions

Authored by ngraham on Jun 16 2019, 5:26 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
VDG
Commits
R119:af9a794695c7: [Task manager] Use consistent menu items for "pin/unpin" actions
Summary

Make the pinning-relatedmenu items consistent by showing separate Pin and Unpin menu
items when not using activities. When using activities, it's unavoidable, so we still
show a more complicated UI there with checkboxes for the per-activity pinning options.

BUG: 395615
FIXED-IN: 5.17.0

Test Plan

Right-click on pinned launchers, open unpinned tasks, and open pinned tasks - see that all have the correct menu items

Do it again with mode than one Activity and see that all is still well

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jun 16 2019, 5:26 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 16 2019, 5:26 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jun 16 2019, 5:26 PM
hein accepted this revision.Jun 17 2019, 10:31 AM
This revision is now accepted and ready to land.Jun 17 2019, 10:31 AM
Closed by commit R119:af9a794695c7: [Task manager] Use consistent menu items for "pin/unpin" actions (authored by ngraham). · Explain WhyJun 17 2019, 1:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 59990

View Options

applets/taskmanager/package/contents/ui/ContextMenu.qml

Loading...