Differential D21855

[IdUtils] Fix aliasing warning
ClosedPublic
Actions

Authored by bruns on Jun 16 2019, 4:37 PM.

Details

Reviewers
ngraham
astippich
poboiko
thiago
Group Reviewers
Baloo
Commits
R293:4651988e2963: [IdUtils] Fix aliasing warning
Summary

memcpy with a small fixed size is optimized by all contemporary compilers
to a few assembly instructions, but contrary to the pointer casting it
lets the compiler do the right thing.

Test Plan

ctest

Diff Detail

Repository
R293 Baloo
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12904
Build 12922: arc lint + arc unit
bruns created this revision.Jun 16 2019, 4:37 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 16 2019, 4:37 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Jun 16 2019, 4:37 PM
ngraham accepted this revision.Jun 16 2019, 5:41 PM
This revision is now accepted and ready to land.Jun 16 2019, 5:41 PM
Closed by commit R293:4651988e2963: [IdUtils] Fix aliasing warning (authored by bruns). · Explain WhyJun 16 2019, 5:50 PM
This revision was automatically updated to reflect the committed changes.
bruns added a comment.Jun 16 2019, 11:28 PM
In D21855#480990, @thiago wrote:

+1

Thx for the confirmation!

thiago added a comment.Jun 16 2019, 11:29 PM

Alternative: return (quint64(devId) << 32) | inode;

Not endian-dependent, like the memcpy solution. Make sure the other side is adapted to match.

bruns added a comment.Jun 16 2019, 11:38 PM
In D21855#480992, @thiago wrote:

Alternative: return (quint64(devId) << 32) | inode;

Not endian-dependent, like the memcpy solution. Make sure the other side is adapted to match.

Thats the problem here - the "other side" is an ondisk DB ...

But removing devId from the ID and just keeping inode is on the todo list, we are asking for trouble here anyway in case of 64bit inodes.

Revision Contents
Changeset List

PathPackages
Msrc/engine/idutils.h (4 lines)

Diff 59939

View Options

src/engine/idutils.h

Loading...