[interactiveconsole] Fix initial load selection
ClosedPublic
Actions

Authored by davidedmundson on Jun 16 2019, 4:06 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

QActionGroup has no signal for when an action within the group changes
checked state. Only when an action within is triggered.

Without calling trigger InteractiveConsole::modeSelectionChanged is not
triggered and m_mode is not updated.

BUG: 408787

Test Plan

qdbus to launch the console
Execute button went to the right place

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

davidedmundson requested review of this revision.Jun 16 2019, 4:06 PM

5.16 please

This revision is now accepted and ready to land.Jun 18 2019, 3:16 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			components/shellprivate/interactiveconsole/interactiveconsole.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	59933	c0f7013		Jun 16 2019, 4:06 PM	★	★
Diff 2	60033	951551b	R120:15de7ceb3875f6b7be7bc55ec43941874fc43e44	Jun 18 2019, 10:22 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
26494ebd4091	12bdba2e56ea	c0f70139ce15	David Edmundson	[interactiveconsole] Fix initial load selection (Show More…)	Jun 16 2019, 4:04 PM