To make it quicker and easier to see all liabilities at once add the (disabled by default) option to hide liabilities that have a zero balance.
Details
Details
- Reviewers
tbaumgart
When this new option is enabled, all liability accounts with a 0 balance do not appear on the home screen summary.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
I'm open to having this option also hide asset accounts with zero balance, though that might be better as a separate option. Personally I'd like to continue to see my zero balance assets to be reminded I need to put something in them at some point (or close them if they are not being useful, etc.)
Comment Actions
Other than that it looks good. Also having a separate option for asset accounts is fair enough.
| kmymoney/views/khomeview_p.h | ||
|---|---|---|
| 1234 | I would change this into: const auto value = MyMoneyFile::instance()->balance((*it).id(), QDate::currentDate());
if (!(KMyMoneySettings::hideZeroBalanceLiabilities() &&
value.isZero())) { | |
Comment Actions
Wow, so looking forward to gitlab. So after a revision has been accepted what's the preferred way to land it? merge? cherry-pick? just rebase on the 5.0 branch and push?
Comment Actions
Rebasing a branch that you have pushed before is usually a bad idea. Since you pushed the branch to the git repo, I recommend to merge it onto the 5.0 branch. That should be possible without problems from what I see.
Using Phab, I keep stuff on a local branch and don't push it but only upload it to Phab using 'arc diff'. Then once approved, I use 'arc land' to create a commit on the branch it should go onto. This way, you get a reference to the Delta-Entry on phab which is automatically closed when you commit (ehm, arc land). See https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages for the details on the 'Differential Revision' keyword.
Hope that helps.
Comment Actions
Awesome, k, I nuked my branch when I modified it. I'll just push the commit on the 5.0 branch and close this revision, makes sense.